Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add resource graph command #1296

Merged
merged 1 commit into from
Sep 29, 2024
Merged

feat: add resource graph command #1296

merged 1 commit into from
Sep 29, 2024

Conversation

Yangyang96
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1277

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@liu-hm19 liu-hm19 changed the title feat: add source graph commnad feat: add resource graph commnad Sep 25, 2024
@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11090350045

Details

  • 208 of 777 (26.77%) changed or added relevant lines in 15 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 51.971%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/apply.go 23 25 92.0%
pkg/cmd/destroy/destroy.go 0 6 0.0%
pkg/engine/resource/graph/storages/util.go 9 15 60.0%
pkg/engine/resource/graph/validation.go 7 17 41.18%
pkg/engine/resource/graph/storages/local.go 10 52 19.23%
pkg/cmd/apply/apply.go 52 106 49.06%
pkg/engine/resource/graph/storages/oss.go 0 66 0.0%
pkg/engine/resource/graph/storages/s3.go 0 78 0.0%
pkg/engine/resource/graph/util.go 59 181 32.6%
pkg/cmd/resource/graph.go 37 220 16.82%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
Totals Coverage Status
Change from base Build 11010137405: -0.9%
Covered Lines: 10322
Relevant Lines: 19861
💛 - Coveralls

@Yangyang96 Yangyang96 force-pushed the feat_graph branch 2 times, most recently from e50f344 to fa0a00f Compare September 25, 2024 06:29
@Yangyang96 Yangyang96 changed the title feat: add resource graph commnad feat: add resource graph command Sep 25, 2024
@Yangyang96 Yangyang96 requested a review from liu-hm19 September 25, 2024 06:37
liu-hm19
liu-hm19 reviewed Sep 25, 2024
View reviewed changes
pkg/cmd/resource/graph.go Show resolved Hide resolved
pkg/cmd/resource/graph.go Outdated Show resolved Hide resolved
pkg/cmd/resource/graph.go Outdated Show resolved Hide resolved
pkg/engine/resource/graph/util.go Outdated Show resolved Hide resolved
pkg/cmd/apply/apply.go Show resolved Hide resolved
@Yangyang96 Yangyang96 force-pushed the feat_graph branch 2 times, most recently from b5408ec to 0ab13bc Compare September 25, 2024 10:00
liu-hm19
liu-hm19 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 199fcbd into KusionStack:main Sep 29, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
@ffforest ffforest linked an issue Dec 10, 2024 that may be closed by this pull request
Feat: Kusion server supports display of resource graph on stacks #1320
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Kusion server supports display of resource graph on stacks Feat: Add application graph
3 participants
@Yangyang96 @coveralls @liu-hm19